php-activerecord icon indicating copy to clipboard operation
php-activerecord copied to clipboard

Declaration of ActiveRecord\DateTime::setTime($hour, $minute, $second = 0) should be compatible with DateTime::setTime

Open des1roer opened this issue 8 years ago • 1 comments

Warning: Declaration of ActiveRecord\DateTime::setTime($hour, $minute, $second = 0) should be compatible with DateTime::setTime($hour, $minute, $second = NULL, $microseconds = NULL) in F:\OpenServer\domains\localhost\ubrir\php\activerecord\lib\DateTime.php

php 7.1

des1roer avatar May 06 '17 04:05 des1roer

This issue has been fixed at #562

Change function to public function setTime($hour, $minute, $second = null, $microseconds = null) { $this->flag_dirty(); call_user_func_array(array($this,'parent::setTime'),func_get_args()); }

But this change needs to be merged to master I think, its not available in new install of the library, so I think it has to be changes manually for now

wilforlan avatar Jun 02 '17 19:06 wilforlan