docsify-copy-code icon indicating copy to clipboard operation
docsify-copy-code copied to clipboard
verified publisher icon jperasmus

Proper keyboard focus boundary is not visible on the ‘Copy to clipboard’ button.

Open msftedad opened this issue 2 years ago • 7 comments

Test Environment: OS: Windows11 OS Version: 23H2 (Build 25905.1000) Browser: Edge Dev (Version 117.0.2007.0 (Official build) dev (64-bit)) URL: PWABuilder - Packaging for the Google Play Store Screen reader: Narrator

Steps to reproduce

  1. Open the URL: PWABuilder - Packaging for the Google Play Store in browser.
  2. Navigate to ‘Copy to clipboard’ button through tab key.
  3. Observe the issue.

Current behaviour Keyboard focus boundary is not visible on the ‘Copy to clipboard’ button present at the page.

Expected behaviour Proper keyboard focus boundary should be visible on the ‘Copy to clipboard’ button.

Attachments: Proper keyboard focus boundary is not visible on the ‘Copy to clipboard’ button1 (1) Proper keyboard focus boundary is not visible on the ‘Copy to clipboard’ button (1)

msftedad avatar Dec 04 '23 10:12 msftedad

This appears to be a theme-specific issue. Please provide details on either the theme or OS-level settings used that produce this error.

jhildenbiddle avatar Dec 04 '23 18:12 jhildenbiddle

Verified this issue is still reproduce on latest environment

Pre-requisite: Open System Settings. Select 'Accessibility' tab. Select 'Color Contrast theme'. In the 'Color Contrast theme' combo box select 'Aquatic/Desert' theme. Test Environment: OS Build: Windows 11 version 23H2 (26040.1000) Edge Browser: Version 122.0.2365.3(Official build) dev (64-bit) URL: PWA Starter - Routing and Navigation (pwabuilder.com) copy to clipboard

msftedad avatar Feb 01 '24 07:02 msftedad

@msftedad Please contribute a PR for this fix. I would be more than happy to review and publish.

jperasmus avatar Feb 20 '24 18:02 jperasmus

@jperasmus, Can you please guide on which we need to add PR? image

msftedad avatar Jun 26 '24 07:06 msftedad

Hi @msftedad You can PR against the master branch, thanks.

jperasmus avatar Jun 26 '24 09:06 jperasmus

@jperasmus, we are unable to create PR for this issue. Could you please help us on creating the PR?

msftedad avatar Jul 08 '24 11:07 msftedad

@msftedad Are you running into permission issues or what is the problem you're experiencing? If it is permission issues, you are likely trying to push directly to a branch on this repo. That won't work. What you should do instead is fork this repo and then create the PR from your branch on the fork to the master branch of this repo.

jperasmus avatar Jul 08 '24 19:07 jperasmus