congo icon indicating copy to clipboard operation
congo copied to clipboard

Blockquote: remove quotation marks

Open aneziac opened this issue 1 year ago • 5 comments

Issue description

Thank you for your help with the Katex issue, got everything working there.

When creating a quote in a blog post, I noticed the theme automatically adds opening and closing quotation marks. This creates a grammatical error when attributing a quote, which is even shown as an official example. I think the quotation marks should be left up to the user.

Image

Offending code seems to be here: https://github.com/jpanther/congo/blob/591610919e6cd2460b581ee259e782de656734c9/assets/css/compiled/main.css#L690C1-L696C2

Theme version

v. 2.11.0

Hugo version

hugo v0.144.1-a79d63a44659b6bc76dcdf223de1637e0bd70ff6+extended linux/amd64 BuildDate=2025-02-18T12:14:07Z VendorInfo=snap:0.144.1

Which browser rendering engines are you seeing the problem on?

No response

URL to sample repository or website

No response

Hugo output or build error messages


aneziac avatar Feb 24 '25 09:02 aneziac

Thanks, I agree that this is less than ideal. It's not a bug per se, as this is the expected behaviour. It stems from Tailwind Typography and that's quite an opinionated plugin. I should be able to override the behaviour with something like the below in the Tailwind config... although I'm currently looking at migrating to Tailwind v4 and that might cause issues with this way of fixing it...

  theme: {
    extend: {
      typography: {
        DEFAULT: {
          css: {
            blockquote: {
              quotes: "none",
            },
          },
        },
      },
    },
  },

Let me think on this a little.

jpanther avatar Feb 24 '25 22:02 jpanther

This issue has been automatically marked as stale because it has not had any recent activity. If you are still experiencing this issue, please review the issue history and add a reply with any requested and/or additional information in order to keep the issue open. This issue will automatically close in 30 days if no further activity occurs.

github-actions[bot] avatar Jun 25 '25 03:06 github-actions[bot]

I see the theme is still using Tailwind v3 so would it be worth making the fix and then revisiting when the v4 upgrade happens?

ned21 avatar Jun 25 '25 04:06 ned21

This issue has been automatically marked as stale because it has not had any recent activity. If you are still experiencing this issue, please review the issue history and add a reply with any requested and/or additional information in order to keep the issue open. This issue will automatically close in 30 days if no further activity occurs.

github-actions[bot] avatar Oct 25 '25 02:10 github-actions[bot]

Still present in v2.12.2. Reproducer code:

> Don't communicate by sharing memory, share memory by communicating.<br>
> — <cite>Rob Pike[^1]</cite>

ned21 avatar Oct 25 '25 18:10 ned21