docker-python-chromedriver icon indicating copy to clipboard operation
docker-python-chromedriver copied to clipboard
verified publisher icon joyzoursky

Improve Images

Open SuperSandro2000 opened this issue 5 years ago • 1 comments

Right now the images don't use any kind of templating I could find cause otherwise I would have done a PR to fix all those issues:

  • apt cache is not getting deleted and apt-get update does not run in the same layer as apt-get install which is against dockers best practices and can lead to caching issues where you never install never packages
  • chromedriver.zip does not get deleted and shipped in the final image which unnecessarily increases image size
  • The script just installs any latest version of Chrome and is not reproducible
  • download mirrors are hard coded
  • older alpine versions are used instead of the latest
  • you run apk update which is not necessary and apk add should be run with --no-cache

SuperSandro2000 avatar Apr 23 '20 07:04 SuperSandro2000

What would it take to add templating so that you could do this?

dvasdekis avatar Jul 13 '20 05:07 dvasdekis