joy icon indicating copy to clipboard operation
joy copied to clipboard

db/insert tries to make a parameter for db/table when params has no table name

Open LeviSchuck opened this issue 4 years ago • 4 comments

While following example code in the authentication docs

It appears that it is attempting to run the following sql

insert into account (password, db/table, email) values (?, ?, ?);

With the params being set to.

@{:db/table @{:keys (:email :password) :required true} :email "[email protected]" :password "....."}

I've tracked this down in the code.. it seems that params will accept input without a table

(def params
  (params # nothing here
    (validates [:email :password] :required true)
    (permit [:email :password])))

while later in the request

(params ?)
(hash-password ?)
(db/insert :account ?)

The correct way of doing things seems to be

(def params
  (params :account
    (validates [:email :password] :required true)
    (permit [:email :password])))
(params ?)
(hash-password ?)
(db/insert ?) # No longer include the table name

It was really confusing to get an error like invalid syntax around /, which required hacking in printf's to find the cause.

LeviSchuck avatar Apr 27 '21 05:04 LeviSchuck

Ah yes, this should definitely throw an error from params, and the docs should be clearer.

Seems like you’re the first one to use joy pretty extensively haha

swlkr avatar Apr 27 '21 05:04 swlkr

Seeing https://news.ycombinator.com/item?id=23046568 On HN is what brought me to Janet.

I just could never write the application I wanted to until I had cryptography primitives.

LeviSchuck avatar Apr 27 '21 05:04 LeviSchuck

I've put up an example project that incorporates the authentication doc material.

There are syntactic problems too that have been resolved in this https://github.com/LeviSchuck/joy-example-auth

LeviSchuck avatar Apr 27 '21 14:04 LeviSchuck

I updated the authentication docs for now, but I think I need a whole new docs section on params and what it does

swlkr avatar Apr 30 '21 23:04 swlkr