cmake-language-support icon indicating copy to clipboard operation
cmake-language-support copied to clipboard

Make dependency on `.NET Install Tool for Extension Authors` extension optional

Open aaronjheng opened this issue 3 years ago • 8 comments

aaronjheng avatar Nov 25 '22 14:11 aaronjheng

+1

dsyx avatar Jan 10 '23 14:01 dsyx

Isn't following the documentation to install a.NET runtime and then configuring cmake.languageSupport.dotnetPath enough?

If you do so, the .NET Install Tool will not be used at all.

josetr avatar Jan 10 '23 16:01 josetr

install a.NET runtime and then configuring cmake.languageSupport.dotnetPath

That's what I'm doing.

the .NET Install Tool will not be used at all

It's the the reason why I suggest making this dependency optional, so I can remove it.

Please consider :)

aaronjheng avatar Jan 11 '23 00:01 aaronjheng

I don't think it's possible to make a VSCode extension dependency "optional" other than releasing a parallel VSCode extension without it. Most people benefit from this dependency to auto-install the .NET Runtime, and as far as I'm aware, there is no harm in having it as a dependency and not using it as is your case.

josetr avatar Jan 11 '23 00:01 josetr

Also is it possible to detect the dotnet path by default? Or maybe check the default installation path first?

FrzMtrsprt avatar Jan 13 '23 15:01 FrzMtrsprt

Hi @josetr ,

There seems to be some issues recently with the .NET Install Tool for Extension Authors extension that the CMake Language Support extension depends on, such as not being able to download .NET 7.0.9. Even though I added "cmake.languageSupport.dotnetPath": "C:/Program Files/dotnet/dotnet.exe" in settings.json, .NET Install Tool for Extension Authors still keeps reporting errors and pop-up dialogue box.

In theory CMake Language Support only needs a .NET runtime, is it possible to remove the dependency on .NET Install Tool for Extension Authors ?

Thanks

dsyx avatar Aug 08 '23 03:08 dsyx

Isn't following the documentation to install a.NET runtime and then configuring cmake.languageSupport.dotnetPath enough?

If you do so, the .NET Install Tool will not be used at all.

The .NET Install Tool for Extension Authors extension automatically downloads the runtime without asking the user, which creates a poor user experience. Even if most people need this plugin, please respect those who do not use it. When installing the Python extension in VS Code, it also automatically installs Pylance, but Pylance can be uninstalled. Why not follow the approach of the Python extension? If a plugin might never be used, why should it be considered a necessary dependency?

YuiHrsw avatar Aug 11 '24 06:08 YuiHrsw