node-browserchannel icon indicating copy to clipboard operation
node-browserchannel copied to clipboard

Provide caching headers

Open wmertens opened this issue 13 years ago • 3 comments

So the current implementation gives the client an etag which is already nice but the browser will still send out a request. Using the connect.static maxAge parameter sets the caching headers so the browser will not even send a request for the code, speeding up the connection.

https://github.com/senchalabs/connect/blob/a9f20e450b8c197e22da41d3d1d610685878489d/lib/middleware/static.js#L168

Since you're not using connect.static I think it may be enough to just add the header at

https://github.com/josephg/node-browserchannel/blob/bfc517f7250eaf17ba6ade4ec02e37ac58eab0bd/lib/server.coffee#L840

but there may be some subtlety involved.

It is desirable to turn off this header while developing the client code, so some sort of option would have to be settable, but I think setting the default to at least a day is probably a good idea.

wmertens avatar Apr 10 '12 22:04 wmertens

Sounds good. Pull request?

josephg avatar Apr 11 '12 02:04 josephg

It's been a while since this was opened, is it still relevant?

wenzowski avatar Feb 23 '14 07:02 wenzowski

I think so - but I'm not sure what the maxAge parameter should be set to. I guess it could be configurable. I won't get to this myself - its too low on my priority list.

josephg avatar Apr 08 '14 18:04 josephg