Gradualizer icon indicating copy to clipboard operation
Gradualizer copied to clipboard

Other cases where lists:nth should pass

Open FrankBro opened this issue 5 years ago • 2 comments

nth1 and nth4 passes. I think it shouldn't be too hard to get nth3 to pass but nth2 will require more finesse. It looks a bit like the guard work I've done previously but it's at a different scope level.

FrankBro avatar Oct 05 '20 22:10 FrankBro

Codecov Report

Merging #290 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files          18       18           
  Lines        2661     2661           
=======================================
  Hits         2334     2334           
  Misses        327      327           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4e95cb...54da3fc. Read the comment docs.

codecov-commenter avatar Oct 05 '20 22:10 codecov-commenter

So from the discussion, ideally we skip nth2 but we try to fix nth3? If so I'll focus on fixing nth3 specifically and move tests where they belong.

FrankBro avatar Oct 21 '20 03:10 FrankBro

I'm closing this due to a long period of inactivity. If there's any will to continue work on this PR we can always reopen it.

erszcz avatar Aug 30 '23 19:08 erszcz