Icons feature request

Open sgurin opened this issue 2 years ago • 1 comments

Hi.

Plugin uses old image sprite technique that has lots of flexibility blockers. For example, if you want to change colors for icons you need to change SVG sprite. Also, issues because of sprite URL https://github.com/josdejong/jsoneditor/issues/675

I think icons could be develop using inline SVG icons approach https://css-tricks.com/cascading-svg-fill-color/

It would be more flexible, accessible and you will remove link to sprint from CSS that is point on lots issues

Sep 18 '23 15:09 sgurin

Thanks for your suggestion. Using a sprite is indeed limiting. The successor of this library, svelte-jsoneditor uses FontAwesome SVG's, that works like a charm.

I'm not planning on replacing the sprite icons myself for jsoneditor, but help would be welcome. Anyone interested in picking this up?

Sep 20 '23 09:09 josdejong