elpy icon indicating copy to clipboard operation
elpy copied to clipboard

Pydantic integration with Jedi 18 fix.

Open gfederix opened this issue 5 years ago • 3 comments

PR Summary

First steps in to integration pydantic. Jedi16 support has been removed. Fixed work of Jedi18. Removed python2 support.

Code reviews and suggestions are welcome. :)

PR checklist

Please make sure that the following things have been addressed (and check the relevant checkboxes):

  • [ ] Commits respect our guidelines
  • [ X] Tests are passing properly (see here on how to run Elpy's tests)

For new features only:

  • [ ] Tests has been added to cover the change
  • [ ] The documentation has been updated

gfederix avatar Feb 28 '21 17:02 gfederix

Oh my, that is a lot of commits :).

Is it ready to be tested and/or used ?

galaunay avatar Mar 28 '21 19:03 galaunay

Oh my, that is a lot of commits :).

Is it ready to be tested and/or used ?

I broke get_docstring. And this is only visible in emacs tests. ;-( Looks like other code works, but I need time to fix broken before merging. And probably write a regression test. I think I'll fix it in early April.

I can also merge my commits into one, if it's convenient.

gfederix avatar Mar 29 '21 15:03 gfederix

Well, I am afraid the test suite is not in a good state at the moment. Some tests fails even on the master branch, so nobody should focus too much on them ATM... We can squash the commits in due time, before merging,

galaunay avatar Jun 30 '21 16:06 galaunay