react-native-quick-actions icon indicating copy to clipboard operation
react-native-quick-actions copied to clipboard

buildToolsVersion conflict

Open SunnyEver0 opened this issue 7 years ago • 3 comments

Could you plz change several parameters such as buildToolsVersion to read from the configuration file of the project root directory? Like this function below:

def safeExtGet(prop, fallback) {
       rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

usage:

compileSdkVersion safeExtGet('compileSdkVersion', 26)
buildToolsVersion safeExtGet('buildToolsVersion', '26.0.2')

SunnyEver0 avatar Dec 28 '18 06:12 SunnyEver0

I assume this is an Android thing. Can you link to some docs and wrap this into a PR? On Fri, Dec 28, 2018 at 1:11 AM SunnyEver0 [email protected] wrote:

Can you change several parameters such as buildToolsVersion to read from the configuration file of the project root directory? Like this function below:

def safeExtGet(prop, fallback) { rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback }

usage:

compileSdkVersion safeExtGet('compileSdkVersion', 26) buildToolsVersion safeExtGet('buildToolsVersion', '26.0.2')

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jordanbyron/react-native-quick-actions/issues/72, or mute the thread https://github.com/notifications/unsubscribe-auth/AACe1uw4Y53vnJHPoKGYwsml5bx45TUCks5u9bX6gaJpZM4ZjfwG .

-- Jordan

jordanbyron avatar Dec 28 '18 13:12 jordanbyron

aha, I'll submit pr soon.thx.

SunnyEver0 avatar Dec 29 '18 02:12 SunnyEver0

@jordanbyron hello, I have already submit the pr, plz review. thanks

SunnyEver0 avatar Dec 29 '18 02:12 SunnyEver0