Missing MIMe headers with NewEmailFromReader

Open tarmo-randma opened this issue 5 years ago • 2 comments

In the latest master version (943e75fe5223047b345337ea74d5951d19d229ed) when e-mails are created with NewEmailFromReader and they contain attachments, the attachments will have empty MIME headers. This is due to commit b84218f6af87ca49ed7465d40545587bd94b379f on Dec 30, 2020 which resolved a different issue. The MIME headers were never covered by a Unit test, so this was not picked up.

The old removed implementation however was also buggy as it set the Content-Id header of the attachment always to the file name. This is incorrect behavior as Content-Id can have a different value and should be read directly from the MIME header.

Feb 16 '21 13:02 tarmo-randma

I have created PR #140 that will resolve this issue

Feb 16 '21 14:02 tarmo-randma

Hi, any release plan about this fix? My project https://github.com/gonejack/email-to-epub is effected by this bug currently.

Mar 16 '21 08:03 gonejack