urh icon indicating copy to clipboard operation
urh copied to clipboard
verified publisher icon jopohl

Feature/signal real timestamp

Open jpacov opened this issue 4 years ago • 4 comments

Adding timestamps to Recorded Signals and ProtocolAnalyzer messages Adding timestamps to messages generated in ProtocolSniffer

Before this PR, signals and messages interpreted by protocol analyzer, had no real timestamps; just some relative time measurements between each messages in signal. Now timestamps are absolute and are saved into proto.xml files correctly for future reference.

jpacov avatar Mar 15 '22 22:03 jpacov

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 15 '22 22:03 CLAassistant

Physical test carried with HackRf One (Native)

jpacov avatar Mar 15 '22 23:03 jpacov

@jopohl Let me know if you need further information.

jpacov avatar Mar 22 '22 02:03 jpacov

@jopohl let me know if further changes are required ;)

jpacov avatar May 02 '22 23:05 jpacov

@jpacov could you please sign the CLA? Probably it wants that again due to the force-push or something.

jopohl avatar Oct 17 '22 15:10 jopohl

Dne @jopohl . It was a problem with 2 accounts mixed. Signed with both now.

jpacov avatar Oct 18 '22 02:10 jpacov

@jopohl can we merge now?

andynoack avatar Jan 21 '23 13:01 andynoack

@jopohl I tested more extensively the timestamps, and made some changes and small fixes. I also added some small unit tests for the ProtocolSniffer as you requested. Let me know if that is enough.

jpacov avatar Feb 24 '23 23:02 jpacov

@jpacov sorry for late reply, could you please pull in latest changes from master? I just updated the CI to support more recent Python versions and like to ensure your changes are compatible.

jopohl avatar Oct 28 '23 11:10 jopohl

With this MR, timestamps for decoded messages are calculated correctly (useful when exporting decoded messages). Working for signals recorded on Record signal window, Sniff protocol window and for signals derivated from other signals (e.g. after filtering a signal).

Here an example: image image image

jpacov avatar Nov 15 '23 14:11 jpacov

@jpacov sorry for late reply, could you please pull in latest changes from master? I just updated the CI to support more recent Python versions and like to ensure your changes are compatible.

@jopohl Done. Let me know if further actions are needed.

jpacov avatar Nov 15 '23 14:11 jpacov

Thank you for your contribution.

jopohl avatar Nov 16 '23 20:11 jopohl