Jon Waldstein comments

Results 71 comments of


                                            Jon Waldstein

New: Donations List Table custom columns and sort

@JasonTheAdams the `_give_subscription_payment` meta is what we call the initial subscription donation. It works in conjunction with subscription `parent_payment_id`. You'll notice in the DonationRepository we manually update this in `give()->donations->updateLegacyDonationMetaAsInitialSubscriptionDonation`...

New: Donations List Table custom columns and sort

@ravinderk re: your comment about `subscriptionId` Unfortunately, I don't think it's that simple. In legacy terms, when a donation has the `subscripton_id` meta, it means it's a _renewal_ and the...

New: Donations List Table custom columns and sort

While I do agree that the donation status of renewal is flawed, I don't think having a donationType property is necessary. In an ideal world, if a donation has a...

fix: remove unnecessary check from give_first and give_email form field

@ravinderk do you feel like we still need to fix this?

fix: multiple same payment methods stored even though logic in place for SEPA

I see we're using the `setup_future_usage` payment intent argument for Stripe (SEPA) which in theory should work. There is also these (newer) docs around the subject. https://stripe.com/docs/payments/sepa-debit/set-up-payment @DevinWalker do you...

GiveWP Payment Gateway label strings should all translate with PolyLang.

@ravinderk do you know if this was resolved?

Custom amount option should not be overridden by the donation levels available when the value is the same

I can confirm this is still happening and a recent canny post has been linked. Although, it's really just how the amount field works by design. That amount field would...

Donations should always show the same date as the payment gateway

@ravinderk @kjohnson can we sneak this fix in somewhere while updating gateways with the gateway api?

Fatal Error: Declaration of Illuminate\Http\Request::get must be compatible with Symfony\Component\HttpFoundation\Request::get

Hey @arnespremberg and @robrecord, Just an FYI we have since updated our php minimum support to php v7.0. I just installed the latest version of sage and givewp and did...

Models should have a meta accessor

This is still something I would like to think through more.