python-hosts icon indicating copy to clipboard operation
python-hosts copied to clipboard

1.0.4 breaking change hosts_path -> path

Open mattrussell-sonocent opened this issue 2 years ago • 1 comments

We had some code that uses python-hosts break on update to 1.0.4 because Hosts.hosts_path was renamed to path in https://github.com/jonhadfield/python-hosts/commit/fa0e8608e132fbf82b4c4184f01eb6d92720966d. Easy to fix once you know about it, but would it be worth adding hosts_path back for backwards compatibility?

mattrussell-sonocent avatar Sep 07 '23 07:09 mattrussell-sonocent

Sorry about that. I should have incremented the minor version, rather than the patch, and made a note.
Do you mean to revert the change, or also include hosts_path and somehow handle both? My issue with the latter is it would make it confusing wrt. setting, getting, and reprs, etc.

jonhadfield avatar Sep 08 '23 18:09 jonhadfield