NebulaLogger icon indicating copy to clipboard operation
NebulaLogger copied to clipboard

New LoggerAdmin queue as fallback record owner

Open jongpie opened this issue 2 years ago • 2 comments

  • Fixes #545 (reported by @mspiep01 in discussion #530)

jongpie avatar Sep 28 '23 03:09 jongpie

Codecov Report

All modified lines are covered by tests :white_check_mark:

Files Coverage Δ
...ore/main/configuration/classes/LoggerParameter.cls 100.00% <100.00%> (ø)
...in/log-management/classes/LogEntryEventHandler.cls 90.92% <100.00%> (+0.32%) :arrow_up:
...g-management/classes/LogManagementDataSelector.cls 100.00% <100.00%> (ø)
.../main/log-management/classes/LoggerEmailSender.cls 93.33% <100.00%> (ø)
...ain/logger-engine/classes/LogEntryEventBuilder.cls 94.57% <ø> (ø)
...-logger/core/main/logger-engine/classes/Logger.cls 96.38% <ø> (ø)

:loudspeaker: Thoughts on this report? Let us know!.

codecov[bot] avatar Oct 01 '23 04:10 codecov[bot]

I'm putting this on-hold for the moment - queues can't be included in managed packages, and since Nebula Logger has both an unlocked package and a managed package, the solution needs to work for both. I'll continue researching options to see what's feasible.

jongpie avatar Oct 04 '23 02:10 jongpie

After letting this PR sit open for several months, I'm going to close this, and I'm not going to release any changes for #545 at this time:

  • The approach used (including a default queue) doesn't work with managed packages, and there isn't a clear alternative approach to use right now that would "just" work out-of-the-box.
  • It also doesn't seem to be a problem any more. If/when others report this is still an issue, we can revisit figuring out how to handle it.

jongpie avatar Jul 07 '24 16:07 jongpie