NebulaLogger icon indicating copy to clipboard operation
NebulaLogger copied to clipboard

Enhancements for logEntryEventStream LWC

Open mar-ben opened this issue 3 years ago • 3 comments

@jongpie I have made the below changes for the enhancement #293

  1. Created a new custom meta data LoggerParameter.LogEntryEventStreamDisplayFields to configure the datatable columns. Let me know if we need to change this name.
  2. Added a new controller class LogEntryEventStreamController to fetch the table columns.
  3. Added splitview to UI.
  4. Enabled fullscreen mode.
  5. Added tabular view.

Please review and let me know your comments. I haven't updated new version on sfdx-project.json yet. will update it after the code review.

mar-ben avatar Jun 25 '22 01:06 mar-ben

@mar-ben thanks so much for working on this PR! My schedule is a little chaotic this week, but I'll finish code review ASAP.

jongpie avatar Jun 28 '22 19:06 jongpie

@mar-ben I'm so sorry for the long delay on getting this PR reviewed! That's completely my fault, I've been moving over the last month & I unfortunately have not had time to work on Nebula Logger. I'm trying to catch up on the project now - my plan is to release a new version of some of my own changes (I'm trying to wrap up the Summer '22 release for Nebula Logger), and then I'll get your PR reviewed/merged afterwards. I hope to have your PR finally reviewed sometime next week, I'll let you know if I have any suggestions on your changes.

Thanks again for all of your help!

jongpie avatar Jul 29 '22 12:07 jongpie

@jongpie No worries. take your time.

mar-ben avatar Aug 04 '22 17:08 mar-ben

@mar-ben I realized I'm able to push changes to the branch for this PR, so I'm going to work on getting this updated & merged in the next few weeks. Thanks again for all of your help!

jongpie avatar Oct 31 '22 14:10 jongpie

@mar-ben I've finally merged this PR! This has been released as v4.9.2 - I made a few minor changes to the code (and added a few small scope-creep items), but nothing drasticly changed.

Thanks again both for your help and your patience with me getting this reviewed & updated, I really appreciate the work you put into this, this changes are awesome.

jongpie avatar Nov 22 '22 23:11 jongpie

@jongpie .. Thank you for merging the changes..

mar-ben avatar Dec 13 '22 18:12 mar-ben

@mar-ben thanks again for all of your help!

jongpie avatar Dec 13 '22 19:12 jongpie