VolumeLockr
VolumeLockr copied to clipboard
Corrected volume max setting not loading properly
Per discussion: https://github.com/jonathanklee/VolumeLockr/issues/3#issuecomment-2068413029
Summary by CodeRabbit
Release Notes
-
New Features
- Updated to support Android SDK version 34.
- Introduced dynamic theming with Material Design components.
- Added a new permission for media playback in foreground services.
-
Improvements
- Replaced
SeekBarwithSliderfor a more modern user experience. - Enhanced application theme to
Theme.VolumeLockrfor better visual consistency.
- Replaced
-
Bug Fixes
- Improved handling of volume settings and preferences.
-
Chores
- Updated build configurations and dependencies for improved performance.
Tested this PR: Stopping the service and starting the app again with "Allow lower than limit" enabled now stays functional as expected.
I did happen to notice if you set the volume lower than the limit while stopping the service and restarting the app, the upper limit gets changed to that lower volume, meaning you'd have to go into the app and turn it back up if wanted. This could be considered a feature rather than a bug though depending who you ask since it could help prevent getting hit with overly-loud volume in some cases.