audio-resampling-in-python
audio-resampling-in-python copied to clipboard
Update torchaudio resampling
Resolves #6
Summary of Changes
- used the latest version of torchaudio (
0.9.0), which contains various resampling improvements - replaced torchaudio
resample_waveformwith the newfunctional.resample, sincecompliance.kaldi.resampleis being deprecated - removed
functional.resamplefrom impulse graphs and replacedfunctional.resamplespectrograms withtransforms.Resampleusing a largerlowpass_filter_widthparameter, similar thejuliusplots.functional.resampleshould numerically matchtransforms.Resample, so plotting both seems redundant - updated README to reflect resampling times in notebook as run on my local machine
Let me know if you have any questions or suggestions!
Huh, I did a review very soon after you created this PR. Where has it gone?! Will have to do it again.