docker-starter icon indicating copy to clipboard operation
docker-starter copied to clipboard

PHPStan level 8 compliance

Open JorickPepin opened this issue 1 year ago • 1 comments

To fix:

------ ---------------------------------------------------------------------- 
  Line   .castor/docker.php                                                    
 ------ ---------------------------------------------------------------------- 
  362    Parameter #1 $data of class Castor\Context constructor expects        
         array{project_name: string, root_domain: string, extra_domains:       
         array<string>, project_directory: string, php_version: string,        
         docker_compose_files: array<string>, macos: bool, power_shell: bool,  
         ...}, non-empty-array<string, mixed> given.                           
 ------ ---------------------------------------------------------------------- 

This may not be the cleanest way to do it, WDYT?

JorickPepin avatar Oct 03 '24 09:10 JorickPepin

This fix seems weird to me. Is there a better way to fix it? IIRC, there one but can't remember 🙃

lyrixx avatar Oct 04 '24 10:10 lyrixx

Hi @lyrixx, I pushed another fix that seems better.

I think we can set PHPStan level 8 by default as this boilerplate is mainly used to create new projects, WDYT?

JorickPepin avatar Nov 10 '24 12:11 JorickPepin