NetAlertX icon indicating copy to clipboard operation
NetAlertX copied to clipboard

SETPWD plugin does not correctly set the password

Open metril opened this issue 1 year ago • 5 comments

Is there an existing issue for this?

  • [X] I have searched the existing open and closed issues and I checked the docs https://github.com/jokob-sk/NetAlertX/tree/main/docs

Current Behavior

Setting the password via the web interface results in the unhashed password written to the app.conf. When the SETPWD is enabled, you cannot login to the webui even if the password is correct.

Expected Behavior

The sha256 hash of the password should be written to the app.conf as described in the conf file and as the transformer dictates.

Steps To Reproduce

No response

app.conf

No response

docker-compose.yml

No response

What branch are you running?

Production

app.log

No response

Debug enabled

  • [X] I have read and followed the steps in the wiki link above and provided the required debug logs and the log section covers the time when the issue occurs.

metril avatar Sep 17 '24 05:09 metril

Thanks a lot for the report and details.

This should be fixed in the next release. It would be great if you could test this. Can you please switch to the netalertx-dev docker image (backup everything at first), in about 15 minutes (or after the last action finishes) from now.

Thanks in advance, j

jokob-sk avatar Sep 17 '24 23:09 jokob-sk

With the most recent dev version, the SAVE button doesn't work. I can check the box and type in a password, but now I cannot SAVE the settings.

metril avatar Sep 18 '24 02:09 metril

Ah...sorry - can you please re-pull in ~15 min - I forgot to remove some debugging code 🤦‍♂️

jokob-sk avatar Sep 18 '24 02:09 jokob-sk

It works now with the most recent dev version.

metril avatar Sep 19 '24 01:09 metril

Thanks for checking! I might push out a new release soon as there are some bugs I'd like to fix in production.

jokob-sk avatar Sep 19 '24 05:09 jokob-sk

Thanks for the report @metril - this should be fixed in the latest release in ~15 min from now -> Closing

jokob-sk avatar Sep 25 '24 22:09 jokob-sk