bazel-deps icon indicating copy to clipboard operation
bazel-deps copied to clipboard

Consider using java_import_external

Open mjduijn opened this issue 7 years ago • 0 comments

By using java_import_external or jvm_maven_import_external it is possible to correctly import dependencies from maven without needing a set of generated BUILD files (please correct me if I'm wrong in this).

If bazel-deps generated a .bzl file with either of the above instead of a custom repository_rule users can get a complete set of dependencies by specifying @org_mockito_mockito_core instead of //third_party/jvm/org/mockito:mockito_core for example.

One more thing: java_import_external makes the //jar suffix optional on imported jars. Some libraries (grpc-java for one) might consider skipping this suffix when using a dependency.

mjduijn avatar Feb 22 '19 08:02 mjduijn