ColRadPy icon indicating copy to clipboard operation
ColRadPy copied to clipboard

Not Compatible with pip install

Open d-v-t opened this issue 1 year ago • 2 comments

I installed with pip install git+https://github.com/johnson-c/ColRadPy.git#egg=colradpy. The following code seems to cause problems as I don't have git installed:

#get the path of the hash so people can track versions, done this way incase the user #didn't pull with git but just zip tssssk tsssk tsssssk base_path = os.path.dirname(os.path.abspath(file)) base_path = base_path[0:len(base_path) - 9] git_dir = pathlib.Path(base_path) / '.git' with (git_dir / 'HEAD').open('r') as head: ref = head.readline().split(' ')[-1].strip() with (git_dir / ref).open('r') as git_hash: self.data['user']['git_hash'] = git_hash.readline().strip()

Because colradpy is not explicitly dependent on git otherwise, this seems like bad practice?

d-v-t avatar Apr 09 '24 21:04 d-v-t

It should work by just downloading the zip from github. You're correct the pip probably broken, this is a fairly low priority for me. If you have fix I would be happy to merge a pull request.

johnson-c avatar Apr 11 '24 20:04 johnson-c

Makes sense. My fix is to comment this code out for now. I'll leave the issue open but will probably not create a pull request anytime soon as it's a similarly low priority for me.

d-v-t avatar Apr 12 '24 19:04 d-v-t