Johno Crawford

Results 107 comments of Johno Crawford

@yujiaxinlong are you sure that you are using 3.0.0-rc10? MappedBytes.java:142 does not map to the delete call in the master branch.

@yujiaxinlong would you kindly enable DEBUG logging for io.atomix.storage.buffer.MappedBytes , reproduce the bug and provide logs?

@franz1981 can you provide a pull request with unit test?

no shouldn't be required, it means the default serializer for the leaderelection code is missing MemberId, setting a custom serializer, especially with reg required false is a hacky work-around.

so after further investigation, I believe the correct fix for this, is to add a new "elementType" configuration to io.atomix.core.election.LeaderElectionConfig and io.atomix.core.election.LeaderElectorConfig then register that in DefaultLeaderElectionBuilder and DefaultLeaderElectorBuilder in...

As a work around you might consider using string of the member id.

@franz1981 lgtm, can you add in your test case from the report too please?

Silly question but you haven't mixed up shutdown and leave right? shutdown name is a little misleading, it doesn't leave the cluster, while leave should drop from the cluster and...

@gawi do you have time to create a prototype / poc or do you have some specific examples? is the javadoc not clear enough?

@kitepad +1... Want to submit a PR? We love contributions :+1: