gridmonger icon indicating copy to clipboard operation
gridmonger copied to clipboard

Error/typo in fileformat.txt

Open Jagholin opened this issue 8 months ago • 1 comments

In fileformat.txt the regn chunk format is described as

'regn'      Regions
    UINT8   enableRegions       (0=off, 1=on)
    UINT16  rowsPerRegion       (min=2, max=3333)
    UINT16  columnsPerRegion    (min=2, max=3333)
    UINT16  numRegions *
    UINT8   perRegionCoords     (0=off, 1=on)

But in reality, numRegions field comes after perRegionCoords: https://github.com/johnnovak/gridmonger/blob/0cde3f8f510dc844e03e537b431ac31a91d605c4/src/persistence.nim#L1380

so the regn chunk is actually

'regn'      Regions
    UINT8   enableRegions       (0=off, 1=on)
    UINT16  rowsPerRegion       (min=2, max=3333)
    UINT16  columnsPerRegion    (min=2, max=3333)
    UINT8   perRegionCoords     (0=off, 1=on)
    UINT16  numRegions *

Maybe there are other errors but I just haven't encountered them yet

Jagholin avatar Aug 30 '25 13:08 Jagholin

Indeed, thanks @Jagholin. I will fix it sometime.

johnnovak avatar Aug 30 '25 16:08 johnnovak