John Lambert
John Lambert
*[`src/SIL.Machine.AspNetCore/Services/MessageOutboxService.cs` line 30 at r8](https://reviewable.io/reviews/sillsdev/machine/197#-O0ANaSlBS-xSsRnWiG_:-O0GC93o9fTFB2ytGZg-:bqdrmmm) ([raw file](https://github.com/sillsdev/machine/blob/1b274bee846b764aa943c17ec92750fc864c70b2/src/SIL.Machine.AspNetCore/Services/MessageOutboxService.cs#L30)):* Previously, ddaspit (Damien Daspit) wrote… All we have to do is add a separate order index property. I think that is actually much...
*[`src/SIL.Machine.AspNetCore/Services/MessageOutboxService.cs` line 38 at r8](https://reviewable.io/reviews/sillsdev/machine/197#-O0AO1WSBr316mFs0Zc-:-O0GC_el-NCyjLJGPIAh:b-iu51nk) ([raw file](https://github.com/sillsdev/machine/blob/1b274bee846b764aa943c17ec92750fc864c70b2/src/SIL.Machine.AspNetCore/Services/MessageOutboxService.cs#L38)):* Previously, ddaspit (Damien Daspit) wrote… I don't think we need this code anymore if we just use the existing pretranslations JSON file. But...
*[`src/SIL.Machine.AspNetCore/Services/ServalPlatformService.cs` line 126 at r9](https://reviewable.io/reviews/sillsdev/machine/197#-O0FVlU7-lDLFLdiippF:-O0GFmFa9OHjOwuiXVhC:b-39ui1a) ([raw file](https://github.com/sillsdev/machine/blob/641902d2ad3be0bd51b742a850d7f6549ff5780b/src/SIL.Machine.AspNetCore/Services/ServalPlatformService.cs#L126)):* Previously, ddaspit (Damien Daspit) wrote… We are unnecessarily serializing and deserializing the pretranslations here. We can just pass in the path to the...
*[`src/SIL.Machine.AspNetCore/Services/ServalPlatformService.cs` line 126 at r9](https://reviewable.io/reviews/sillsdev/machine/197#-O0FVlU7-lDLFLdiippF:-O0GGQUkAaFXtZV8fLDt:b-5d0rg0) ([raw file](https://github.com/sillsdev/machine/blob/641902d2ad3be0bd51b742a850d7f6549ff5780b/src/SIL.Machine.AspNetCore/Services/ServalPlatformService.cs#L126)):* Previously, johnml1135 (John Lambert) wrote… The request content is a string. Should we make it just a byte array instead? We will need...
*[`src/SIL.Machine.AspNetCore/Configuration/IMachineBuilderExtensions.cs` line 267 at r8](https://reviewable.io/reviews/sillsdev/machine/197#-O0AR1XrA9vyPSCHx55M:-O0Gr_hO4fWaQtxML0aZ:b-klwrcd) ([raw file](https://github.com/sillsdev/machine/blob/1b274bee846b764aa943c17ec92750fc864c70b2/src/SIL.Machine.AspNetCore/Configuration/IMachineBuilderExtensions.cs#L267)):* Previously, ddaspit (Damien Daspit) wrote… I would really like to stick with the convention. What about `outboxes`? `sortable_indexes`?
Would it spin up a docker image containing machine.py? Probably it would be better to have one master docker image that has both .net and python packages - and all...
It would be nice to have a development docker container image in Serval that can hold all 3 repos and truly build it. If it needs to be a separate...
*[`src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs` line 113 at r3](https://reviewable.io/reviews/sillsdev/machine/233#-O4fvmsACOQYjSuLfqsb:-O4fvmsACOQYjSuLfqsc:bwy2814) ([raw file](https://github.com/sillsdev/machine/blob/ec31107bd421cbcb187bf68153c1329ab8a3a744/src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs#L113)):* > ```Smalltalk > ); > } > string languageCode = languageIsoCodeSettingParts[0]; > ``` So we want to crash if there is no language...
*[`src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs` line 113 at r3](https://reviewable.io/reviews/sillsdev/machine/233#-O4fvmsACOQYjSuLfqsb:-O4fxdmG4sxc3ATZF6UX:b-sg1qn4) ([raw file](https://github.com/sillsdev/machine/blob/ec31107bd421cbcb187bf68153c1329ab8a3a744/src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs#L113)):* Previously, ddaspit (Damien Daspit) wrote… A Paratext project should have a defined language code setting. Of course, we have learned that anything can...
*[`src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs` line 113 at r3](https://reviewable.io/reviews/sillsdev/machine/233#-O4fvmsACOQYjSuLfqsb:-O4jjQeR-GgIZZC4FX7m:b9qyb8y) ([raw file](https://github.com/sillsdev/machine/blob/ec31107bd421cbcb187bf68153c1329ab8a3a744/src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs#L113)):* Previously, Enkidu93 (Eli C. Lowry) wrote… Alright. @ddaspit - you understand the range of Paratext projects better. What do you think the default...