OpenStreetView icon indicating copy to clipboard operation
OpenStreetView copied to clipboard

[patch] Remove direct dependency to ajax.googleapis.com (privacy issue)

Open tetraf opened this issue 12 years ago • 7 comments

Patch to use with git apply: https://gist.github.com/tetraf/5611870

tetraf avatar May 20 '13 12:05 tetraf

Is @johnmckerrell no longer maintaining this repository? If I made a pull request with the patch above, would it be accepted?

alexandre-mbm avatar Mar 05 '14 08:03 alexandre-mbm

I'm still here but don't get time to do anything with OSV, if you submit a pull request I should be able to apply it.

johnmckerrell avatar Mar 05 '14 11:03 johnmckerrell

Thank you. I will do some requests in the coming days.

Can you tell which is the license you want to use?

alexandre-mbm avatar Mar 05 '14 11:03 alexandre-mbm

I have a local branch for pull request. I used the tips about git apply. I made the fixes about which I commented at the Gist tetraf/remove_googleapis.patch. I ran a quick test and it showed no problems.

Accepting the pull request will entail accepting the jQuery's code dual licensed under the MIT (MIT-LICENSE.txt) and GPL (GPL-LICENSE.txt) licenses. Do I send the pull request?

alexandre-mbm avatar Mar 13 '14 11:03 alexandre-mbm

Yes please do, I think it's fine to do that as a library.

On 13 Mar 2014, at 11:44, Alexandre Magno [email protected] wrote:

I have a local branch for pull request. I used the tips about git apply. I made the fixes about which I commented at the Gist tetraf/remove_googleapis.patch. I ran a quick test and it showed no problems.

Accepting the pull request will entail accepting the jQuery's code dual licensed under the MIT (MIT-LICENSE.txt) and GPL (GPL-LICENSE.txt) licenses. Do I send the pull request?

— Reply to this email directly or view it on GitHub.

johnmckerrell avatar Mar 13 '14 11:03 johnmckerrell

But we would be redistributing it. No problem?

alexandre-mbm avatar Mar 13 '14 12:03 alexandre-mbm

I'm going to say "Yes", no problem. I believe it's ok as a library.

On 13 Mar 2014, at 12:10, Alexandre Magno [email protected] wrote:

But we are redistributing it. No problem?

— Reply to this email directly or view it on GitHub.

johnmckerrell avatar Mar 13 '14 12:03 johnmckerrell