John Hooks
John Hooks
Would all of core be considered [@internal](https://api-extractor.com/pages/tsdoc/tag_internal/)?
Totally understand. I started trying to use it in some private projects and it's been educational. I'll try to push a new commit that implements some of what I've learned....
@sarahdayan I modified `packages/dinero.js` to use api-extractor. Now that package's script`build:types` generates a single type file into `dinero.js/packages/dinero.js/dist/dinero.js.d.ts`. I did need to make a few changes to incorporate api-extractor, some...
I added `api-extractor` to `@dinero.js/currencies`. Are all the currencies generated by a script or written by hand? To quiet `api-extractor` warnings about commenting which exports are public I need to...
~~@sarahdayan over all, my feelings about this solution is that it's complex and `api-extractor` is built to be incorporated into monorepos managed by `rush`. I'm going to look at https://github.com/wessberg/rollup-plugin-ts,...
@sarahdayan when I rebased into main, it changed my main branch, not the `add-api-extractor` branch. Sorry I'm very new to the PR/git process.
@sarahdayan is that supposed to take me though a long interactive process for each commit? Just making sure I'm doing this right.
@sarahdayan I already merge upstream in https://github.com/dinerojs/dinero.js/pull/499/commits/0b541b02b0fa314b69d8203e3f9b010357f6f8e6
@sarahdayan okay, I'll keep slogging through this. One issue I'm having, vscode isn't allows suggesting to open the merge editor. whats the right cli way to resolve merge conflicts
@sarahdayan I think I did it!