johnezang
Add Unit Tests to repository
I'm assuming you have some form of automated tests, and I think these should be available in the repository. For those of us making modifications on the codebase it's pretty essential that we have some tests to make sure we are not breaking stuff.
I definitely agree with this. The only problem(s) I have with it are purely practical. The testing harness I have for JSONKit is a hodgepodge of kludged together scripts. It would have to be significantly cleaned up to make it something I wouldn't be embarrassed to commit to a public repo.. :)
However, should you be so inclined, I did borrow... well, all of the tests that are available in the jannson JSON library. Off the top of my head, that was by far the most comprehensive set of JSON tests I found, and there is a particular emphasis on testing corner cases.
Sadly, I'm not going to promise anything on this request... It's something I should unquestionably do, but there's that evil time and effort required vs gains demon.. :) I'll leave it open as a reminder that I really should get around to doing this.
There is a 3rd alternative:
put the unit tests and other cruft into a project called JSONKitTests and link to that project near the top of README.md.
Long term, you could figure out how to merge the two projects or whatever.
Having the code as a simple 2-file JSONKit.{m,h} is really nice, but I was concerned about the lack of tests when I ran across this project. However, after reading the details on spec compliance, I concluded that there's just no way this project isn't tested.
