Stupid-Table-Plugin icon indicating copy to clipboard operation
Stupid-Table-Plugin copied to clipboard
verified publisher icon joequery

Support for mobile devices

Open Surfoo opened this issue 10 years ago • 4 comments

Surfoo avatar Feb 28 '15 22:02 Surfoo

Thanks for the pull request. Did the tests pass with your adjustments? And what mobile device was the plugin failing on before?

joequery avatar Feb 28 '15 22:02 joequery

Oh sorry, I didn't execute the tests...

I have a Nexus 5 with Lollipop and I just tried with Chrome. Maybe you will need to test with more devices, I don't know and I have only this smartphone.

Surfoo avatar Feb 28 '15 22:02 Surfoo

Hey there,

So I'm finally getting around to merging this in, and the code is actually incorrect.

$(this) within the callback function provided to all refers to the th we want sorted. If you take $(this) out of the callback context, it refers to the entire table instead of the th.

I will incorporate your first commit though :)

joequery avatar May 04 '15 23:05 joequery

It seems that touchend and click are not mutually exclusive events. Consequently, devices that support both will have a 'doubleclick' effect. Not quite sure what to do about this, there doesn't seem to be a 100% accurate solution based upon my research.

joequery avatar May 04 '15 23:05 joequery