react-native-cookies icon indicating copy to clipboard operation
react-native-cookies copied to clipboard
verified publisher icon joeferraro

Publish webkit support

Open Nhacsam opened this issue 7 years ago • 3 comments

Hello, Thanks a lot for this very useful library.

I would like to use the new useWebkitparameter but it's not published on npm yet. I have the same error as #78 Can you publish it ?

Thanks

Nhacsam avatar Oct 26 '18 15:10 Nhacsam

Hi thanks for the note. If you could run through some manual tests of master, that'd be helpful.

joeferraro avatar Oct 26 '18 16:10 joeferraro

Hello, The first thing I saw is that the getAll method have been duplicated :

  • https://github.com/joeferraro/react-native-cookies/blob/master/ios/RNCookieManagerIOS/RNCookieManagerIOS.m#L212
  • https://github.com/joeferraro/react-native-cookies/blob/master/ios/RNCookieManagerIOS/RNCookieManagerIOS.m#L233

I will do more advanced test later

Nhacsam avatar Oct 26 '18 17:10 Nhacsam

I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store We can create issues and PRs there to continue the development of the project.

safaiyeh avatar Jan 02 '20 19:01 safaiyeh