sql-language-server Help - Adding Oracle support

I have beyond zero experience with JS-flavor languages, but am interested in adding Oracle support. Would the best place to base my ventures off of be something like this commit (which added BigQuery)?

Any other general advice in this respect?

Jan 20 '22 17:01 levouh

@levouh Hi, thanks for your kind offer! Sure, support additional vendor is always welcome! If you need some our help, please feel free to ping me, thanks. 🙏

Jan 25 '22 13:01 joe-re

Well so the first question was generally around what a good commit/PR to base my changes off of would be. Do you recommend the one that added BigQuery or something else @joe-re?

Jan 25 '22 14:01 levouh

@levouh Yes, that PR would be a good example. Basically getting DB info is going to be vendor-specific implementation. database_libs (packages/server/src/database_libs) is expected to wrap this specific implementation part. So if we want to support additional vendor(in this case, for Oracle) adding database_libs/OracleClient.ts would be the first step.

Jan 27 '22 00:01 joe-re