jobtoday
Added Image Loading Customisation
Features
- Added option to hide default loading (react activity indicator)
- Added option to add custom loading component
- Added option to pass onImageLoad which is called when the image loads
Notes
This is my first time contributing to an open source project so I hope I've done everything correctly :)
so I hope I've done everything correctly
Hey so this is cool, however there's one thing that is not quite correct..
By the looks of the diff in github, it seems you changed the entire project because your IDE added tabs and some interesting spacing. Also you changed the quotes to single. Therefore it looks like you added 564 new lines, but you certainly did not.
You should try to match the project editor style so next time your PR would only show the changes you made. Granted this project does not have shared configuration (like Prettier), so it is a little bit harder. However you can adjust your text editor/IDE preferences and try and match the source code a little better. Because right now, it is impossible to see what your intentional changes are vs what your IDE changed.
so I hope I've done everything correctly
Hey so this is cool, however there's one thing that is not quite correct..
By the looks of the diff in github, it seems you changed the entire project because your IDE added tabs and some interesting spacing. Also you changed the quotes to single. Therefore it looks like you added 564 new lines, but you certainly did not.
You should try to match the project editor style so next time your PR would only show the changes you made. Granted this project does not have shared configuration (like Prettier), so it is a little bit harder. However you can adjust your text editor/IDE preferences and try and match the source code a little better. Because right now, it is impossible to see what your intentional changes are vs what your IDE changed.
Oh okay I see. Sorry! I'll fix that and create a new pull request with just the changes I intended. Thanks for pointing that out 👍