TournamentStreamHelper icon indicating copy to clipboard operation
TournamentStreamHelper copied to clipboard

5.7: Null values from Startgg are not treated as a blank string

Open ladyisatis opened this issue 2 years ago • 1 comments

Screenshot 2023-06-29 150939

Essentially, any data that has a value of null (e.g. players) are treated as if it should skip updating any fields like scores or player names, instead of as a blank string. I've attached an image which should be a 2-1 in Hbox's favor vs. Dunktastic, This is using the "Load tournament and sets from StartGG user" feature, where currently the screenshot has loaded a set that does not have an opponent for Hbox (Winners Semi-Final).

Another example that sometimes pops up are that if an opposing player's pronouns are she/her, and that's set in Startgg, and Hbox has won against her, it'll load up the next set after that Hbox has... but said player will not have put anything in the pronoun field. Hbox's opponent will still have the "she/her" pronouns set, despite the player not having it set in the profile.

This gets fixed when the program is restarted.

This bug itself led to the pronoun issue that plagued Hbox at the SF6 Coinbox alongside async race conditions, see https://github.com/joaorb64/TournamentStreamHelper/issues/450 on that.

ladyisatis avatar Jun 29 '23 22:06 ladyisatis

Note: This is in 5.7

Wolfy76700 avatar Jun 29 '23 22:06 Wolfy76700