react-github-login icon indicating copy to clipboard operation
react-github-login copied to clipboard

Not calling onSuccess when response with address line contains temporary code has been received

Open JaroslavK-v opened this issue 7 years ago • 3 comments

I receive response from github with code in adress line like http://127.0.0.1:3000/auth/?code=65...785 but nothing happens. Looks like promice not resolves, but it will be rejected, if I close the popup and then onFail works fine.

JaroslavK-v avatar Apr 01 '18 14:04 JaroslavK-v

Hi @JaroslavK-v , you need a serverside logic. #10 may help you.

tam315 avatar May 03 '18 01:05 tam315

I'm also having this issue, has anyone been able to fix it?, It's a cross-origin problem DOMException: Blocked a frame with origin "base URL here" from accessing a cross-origin frame

Mozartted avatar Jun 16 '18 17:06 Mozartted

I think I fixed it, just make sure the popup window's callback address is on the same domain as the main window, i.e if the main window is on your localhost:8000 but the callback on github app is http://domainname.local/callback, DOMExpection error kicks in, try to access the app via the domainname.local host which should be made connected to the localhost in the /etc/hosts file

Mozartted avatar Jun 17 '18 23:06 Mozartted