CONTRIBUTORS and Contributors folders need to be deleted.
@jlord:
CONTRIBUTORS and Contributors folders have been created.
When cloned on a Mac they overwrite the contributors folder with a CONTRIBUTORS folder.
- If you create the
add-username.txtfile in youradd-usernamebranch in theCONTRIBUTORSfolder and commit,reporobotwill not find it. - If you rename
CONTRIBUTORStocontributors, then add the file and commit,reporobotwill not find it. - If you delete
CONTRIBUTORS, createcontributors, then add the file and commit,reporobotwill find it and add the picture. BUT, when you submit the pull request, you get a complaint about too many files. https://github.com/jlord/patchwork/pull/27931
The CONTRIBUTORS and Contributors folders need to be deleted. And there must be some way to prevent others from recreating them, or to prevent reporobot from merging them in a pull request.
Yes, these 3 case-different folders are a PITA for Windows and Mac users, since the filenames/foldernames are case insensitive for these two OS.
I did this:
- delete the
CONTRIBUTORSandContributorsfolder - creating a
tmpfolder and store myadd-usernam.txtin it - rename this
tmpfolder tocontributors. I'm not so sure, but I thinkgit mvworks better thanmvalone in this regard: with the first one I getcontributors/add-usernam.txtin y commit, but with the latest I getCONTRIBUTORS/add-usernam.txt. I'm too much of a beginner to understand why... -
git statusto check the only things that will be committed iscontributors/add-usernam.txt(no deletion of anything) - commit/push/pull-request
My pull-request has been accepted, and I now have my name on the webpage!
... but I can't see my file in the contributors folder of jlord's depo ¯_(ツ)_/¯
Hey!
Sorry, that folder is supposed to be getting periodically cleared so that it doesn't get so huge but that's apparently broken 😢 I'll open an issue for it on https://github.com/jlord/reporobot/issues/40.
This is still an issue btw...
anyone else stuck theres another "Patchwork" folder within patchwork that contains "contributors":
- Lesson 7 Branches Aren't Just For Birds
- cd Patchwork
- when you get to "$ git add <FILENAME>" put "git add contributors/add-yourUsername"
The patchwork>contributors folder is not actually the solution anymore, at least on Windows. I have tried putting my txt file in all of the different 'contributors' folders, as well as deleting the nested contributors folder. The only time I manage to push at all was when I had the txt file in completely the wrong folder (the top level project folder), but I cannot replicate that and I was unable to make that merge. @jlord