ncdump-json icon indicating copy to clipboard operation
ncdump-json copied to clipboard

support cdl without global attributes

Open ocehugo opened this issue 10 years ago • 4 comments

If the cdl file has no global attributes, the json dump output of ncdump-json is invalid.

ocehugo avatar Sep 29 '15 07:09 ocehugo

Thank you for reporting, I'll try to make some research on it, I have very limited time to work on this. Pull requests are also welcome.

jllodra avatar Sep 30 '15 21:09 jllodra

If i remember correctly, the problem was with a extra "}" at the end of the file. So pretty much believe that is some if global_attributes_present missing (the assumption that all files have them), that includes the extra "}".

ocehugo avatar Sep 30 '15 23:09 ocehugo

Makes sense, thanks for the research.

jllodra avatar Oct 01 '15 10:10 jllodra

Commit 3e5301c9e897fa46a4b1e114527d3c4e803e00a4 should fix this. :+1:

jllodra avatar Oct 02 '15 17:10 jllodra