speedscope icon indicating copy to clipboard operation
speedscope copied to clipboard

XCode Instruments 16 breaks Deep Copy format import

Open akumansley opened this issue 1 year ago • 1 comments

Here's a sample Deep Copy from Instruments 16, which seems to have slightly different spacing:

Weight	Self Weight	Symbol Names
2.18 s  100.0%	0 s	 node (98674)
1.98 s  90.8%	0 s	  start
1.98 s   0.0%	0 s	   node::Start(int, char**)
1.98 s   0.0%	0 s	    node::LoadSnapshotDataAndRun(node::SnapshotData const**, node::InitializationResult const*)
1.98 s   0.0%	0 s	     node::NodeMainInstance::Run()

akumansley avatar Sep 19 '24 18:09 akumansley

Hi! Thanks for the heads up. I'd accept a PR to resolve this while still maintaining functionality for past versions of Instruemnts. The relevant file to change is importFromInstrumentsDeepCopy

jlfwong avatar Sep 19 '24 19:09 jlfwong

Hi there, unfortunately, I also have a broken .trace from use of XCode 16. When do you think it can go productive with this fix?

MAUIoxo avatar Nov 16 '24 09:11 MAUIoxo

@akumansley @robert3005 This is now merged and live on https://www.speedscope.app/

@MAUIoxo Unfortunately, I think your issue is slightly different an unlikely to be resolved. Instruments' file format has evolved significantly since I wrote the support for Instruments import and I never got around to doing the added reverse engineering work to figure out what's going on. See #196. It's possible using "deep copy" as a workaround will still allow you to accomplish what you need to though.

jlfwong avatar Nov 17 '24 06:11 jlfwong