mnamer icon indicating copy to clipboard operation
mnamer copied to clipboard

Improvements to Quality String

Open thekiefs opened this issue 5 years ago • 0 comments

I think a few improvements will go a long way for the quality string:

  1. Allow calling separate sub-strings to the current {quality} string such as a) resolution b) source c) video encode d) audio encode. This would allow new identifiers like {resolution} to be separate from {source}, etc. and can be called independently rather than incorporating all those identifiers into the quality string.

  2. Add proper capitalization and formatting of the quality string. Right now 720p.WEB-DL.AAC2.0.H.264-CtrlHDgets turned into 720p web aac h.264 when I think it should really be 720p Web AAC H.264

  3. Fix what is included in the quality string (can be solved by 1.) Some things that are not necessarily quality strings are included in the {quality} tag. For instance, version is important and some users would want to call that out specifically. While this might fall outside the scope of the quality string, right now mnamer --movie-format '{name} ({year}) ({quality}){extension}' turns

The.Two.Towers.2002.Extended.1080p.BluRay.DTS-ES.x264-HiD.mkv

into

The Lord of The Rings The Two Towers (2002) (1080p blu-ray dts extended surround h.264).mkv

Personally, I need extended to be called out specifically instead of being included in the quality string. Also not sure why DTS changes to surround, is that a bug?

thekiefs avatar Jun 28 '20 15:06 thekiefs