CellChat icon indicating copy to clipboard operation
CellChat copied to clipboard

Incorrect documentation / use of thresh.pc argument

Open ATpoint opened this issue 2 years ago • 2 comments

Hello,

in ?identifyOverExpressedGenes() it says that for thresh.pc Threshold of the percent of cells expressed in one cluster. However, in the code on multiple occasions such as https://github.com/jinworks/CellChat/blob/main/R/utilities.R#L374 you multiply this by 100, suggesting that either the "*100" needs to be removed everywhere or documentation must state that the argument takes the a fraction rather than percentage.

best wishes!


Initially posted to old https://github.com/sqjin/CellChat/issues/752

ATpoint avatar Jan 24 '24 10:01 ATpoint

@ATpoint Thanks. Will use fraction in the next update.

sqjin avatar Jan 24 '24 10:01 sqjin