node-http-link-header

node-http-link-header copied to clipboard

Make parse fn robust when undefined

6

When you do something like `LinkHeader.parse(undefined)` it crashes with: ``` Uncaught TypeError: Cannot read property 'replace' of undefined ``` I'd make this a bit more robust and would just return...

binarykitchen

As of `v1.0.3` non-token attributes are escaped a bit too aggressively (see https://github.com/jhermsmeier/node-http-link-header/commit/6bad07ca27092118d97e9cda77ba2143c4daa45e#commitcomment-43076368) As per [RFC 7230, Section 3.2.6](https://tools.ietf.org/html/rfc7230#section-3.2.6): > A sender SHOULD NOT generate a quoted-pair in a quoted-string...

jhermsmeier

There needs to be some more investigation into extended attributes and their usage in the wild. So far I've only come across `text*` in the spec, but haven't seen it...

jhermsmeier