jfrog-cli icon indicating copy to clipboard operation
jfrog-cli copied to clipboard
verified publisher icon jfrog

Gradle Proxy Enablement ignores no_proxy rules

Open Enquier opened this issue 5 years ago • 4 comments

Describe the bug The changes introduced in #359 while important disable the ability to specify a proxy for resolving external dependencies while publishing to an internal repository. For example you might be pulling from an external repository such as external jcenter() or in my case a non-ivy non-maven source that needs manipulation before it can be added to artifactory

To Reproduce

  1. Configure jfrog/gradle to use http/https_proxy with no_proxy for internal sites (ive tried both IP's and DNS names)
  2. Configure a dependency resolution repository that requires a proxy to access
  3. Perform gradle tasks including dependency resolution via proxy
  4. Publish Artifacts to internal Artifactory

Expected behavior Gradle/Artifactory plugin to respect no_proxy rules

Versions

  • JFrog CLI version: Latest
  • JFrog CLI operating system: debian/docker
  • Artifactory Version: 6.17.0

Additional context Gradle: 4.10.2

Enquier avatar Jun 06 '20 02:06 Enquier

@Enquier, Thanks for reporting this. We should probability add a "bypass http proxy" option when configuring an Artifactory server through the jfrog rt c command. What do you think?

eyalbe4 avatar Jun 06 '20 05:06 eyalbe4

That would be a great/more general way to manage internal vs external rt servers/other repositories. My use case is rather complex in that I am downloading from an external non-artifactory system manipulating (mostly formatting for maven) that artifact slightly and posting it to our internal artifactory. Either way your proposal sounds like it would work for my use-case

Enquier avatar Jun 06 '20 12:06 Enquier

I have added a PR with a fix for this. CLA is not available via link anymore

Enquier avatar Jun 07 '20 15:06 Enquier

Hi, do you have any update about this issue? I have similar problem with gradle deployment, it ignores NO_PROXY env (there is no such issue for mvn or npm). Only one workaround which works is to unset HTTP_PROXY env before running jf gradle artifactoryPublish... jfrog cli version: 2.59.1

joanna-polec avatar Jul 26 '24 19:07 joanna-polec

@joanna-polec
JFrog CLI version 2.65.0 has been released, and it includes a fix for the no-proxy issue during deployment. Please give it a try and let us know your feedback.

yahavi avatar Aug 30 '24 06:08 yahavi

@yahavi It works on version 2.65.0, thanks!

joanna-polec avatar Sep 02 '24 09:09 joanna-polec