jfrog-cli icon indicating copy to clipboard operation
jfrog-cli copied to clipboard

Published scoped npm packages gets wrong path using JF CLI

Open elumalaigjfrog opened this issue 2 years ago • 6 comments

Describe the bug

I did create one scope package for testing and pushed two versions 1.0.0 and 2.0.0 to the local repo using both NPM and JF CLI respectively. The customer has seen a difference in path when it comes to scoped packages when pushed with JF CLI 2.50.2. #npm view @test/[email protected] dist.tarball http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/[email protected] dist.tarball

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz I can view the difference in the path when it comes to scoped packages and not regular ones.

Current behavior

I did create one scope package for testing and pushed two versions 1.0.0 and 2.0.0 to the local repo using both NPM and JF CLI respectively. The customer has seen a difference in path when it comes to scoped packages when pushed with JF CLI 2.50.2. #npm view @test/[email protected] dist.tarball http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/[email protected] dist.tarball

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz I can view the difference in the path when it comes to scoped packages and not regular ones.

Reproduction steps

Create a NPM scoped package Use JF CLI to publish the package.

Expected behavior

#npm view @test/[email protected] dist.tarball - npm client http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/[email protected] dist.tarball - JF CLI

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz

I can view the difference in the path and it should be same.

JFrog CLI version

2.50.2

Operating system type and version

Mac

JFrog Artifactory version

No response

JFrog Xray version

No response

elumalaigjfrog avatar Oct 23 '23 12:10 elumalaigjfrog

I could reproduce this and face the same issue. It is important to point out though that the npm install for the package published via JFrog CLI still works, but it's still an inconvenience.

niklas2810 avatar Oct 24 '23 14:10 niklas2810

I was also able to replicate this, publishing using the native "npm publish" command results in duplicate scope in the path.

Same as the example @elumalaigjfrog provided: //localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

That's not the case using jfrog-cli or the Artifactory plugin for Jenkins.

DiyanDev avatar Dec 11 '23 12:12 DiyanDev

Any update on this topic? Having the same issue with local npm publish:

https://my.artifactory/artifactory/my-releases//@my-team/other/-/@my-team/other-test-0.0.16.tgz

pauloazevedo88 avatar Jan 11 '24 17:01 pauloazevedo88

Hi, I have also encountered the same issue. Waiting for this fix.

joanna-polec avatar Sep 10 '24 07:09 joanna-polec

Hey, having the same issue. Hoping for the fix soon.

wojtekkosowicz avatar Sep 10 '24 07:09 wojtekkosowicz

👉 https://github.com/jfrog/build-info-go/pull/273

connyay avatar Sep 16 '24 16:09 connyay