jfrog-cli-core icon indicating copy to clipboard operation
jfrog-cli-core copied to clipboard

move depTree logic from 'xrayutils.go' file

Open asafambar opened this issue 1 year ago • 2 comments

  • [X] All tests passed. If this feature is not already covered by the tests, I added new tests.
  • [X] All static analysis checks passed.
  • [X] This pull request is on the dev branch.
  • [X] I used gofmt for formatting the code before submitting the pull request.

asafambar avatar May 01 '24 18:05 asafambar

@eyalbe4 moved most logic from xrayutils to security repo, the file still have one function which is in use in the core project

asafambar avatar May 02 '24 15:05 asafambar

@eranturgeman / @attiasas / @hadarshjfrog - Are you good with the removal of this code, and its addition to the jfrog-cli-security module? If so, I suggest we remove it only once the code is merged (or is about to be merged) to jfrog-cli-security, to allow us to release jfrog-cli at any point of time. Awaiting your green light to merge this.

eyalbe4 avatar May 02 '24 15:05 eyalbe4

Can we go ahead and merge this PR @attiasas? Would you like to merge the relevant code to jfrog-cli-security first?

eyalbe4 avatar May 21 '24 04:05 eyalbe4