jfrog-cli-core icon indicating copy to clipboard operation
jfrog-cli-core copied to clipboard
verified publisher icon jfrog

Remove applicabilityScannable attribute for technology

Open attiasas opened this issue 1 year ago • 2 comments

  • [x] All tests passed. If this feature is not already covered by the tests, I added new tests.
  • [x] All static analysis checks passed.
  • [x] This pull request is on the dev branch.
  • [x] I used gofmt for formatting the code before submitting the pull request.

This attribute is no longer needed. the new scanners will return a new status 'NOT_SCANNED' if not supported yet.

attiasas avatar Mar 12 '24 12:03 attiasas

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

github-actions[bot] avatar Mar 12 '24 13:03 github-actions[bot]

The code change itself looks good - my only concern - is how can we validate that when scanning a non-supported technology - just nothing well happened (as expected) - and not break anything?

Is it all handled here? https://github.com/jfrog/jfrog-cli-security/pull/37/files

hadarshjfrog avatar Mar 24 '24 11:03 hadarshjfrog