James Tomlinson
James Tomlinson
@e-lancaster if you are able you can try the changes in #1002? This will not fix the reported issue, but should result in an error instead.
Version 1.15.3 should now error on this type of model configuration.
I've been thinking a long-term solution to this problem. I think the fundamental problems is that the nodes are added to the networkx graph that aren't really part of the...
@Batch21 thoughts on the above?
I'm pretty sure the changes in #1002 might be triggered failures when there are isolated nodes (that shouldn't be). For example, if there is a reservoir not connected to anything....
OK. These should all be caught earlier with an easier understand error message.
This has become even more apparent with some recent requests. Such as the the full flow duration curve. I'm not sure what a generic API would look like. Perhaps we...
Related to #182
https://github.com/pywr/pywr/blob/e7b4e35c5eef08442e1f390c4a5b8270cb0ae926/pywr/parameters/parameters.py#L118 Just rename `x` and `y` to `volumes` and `values` respectively? Same issue here: https://github.com/pywr/pywr/blob/e7b4e35c5eef08442e1f390c4a5b8270cb0ae926/pywr/parameters/parameters.py#L140
> Also it is not possible to set any of the interp_kwargs in the json other than the kind. Maybe the loads function should assume that anything left in data...