Nikolay Novik

Results 118 comments of Nikolay Novik

@sjscotti Would you like to submit PR with proposed fix? Could be counted as part of [hactoberfest](https://hacktoberfest.digitalocean.com/).

Yep i have plan to add `@torch.no_grad()`, hopefully will find time do to this soon.

Not sure when I will be able to take a look, but happy to accept PRs with fixes.

Thanks! I am planning to rework that part anyway, give me some time to think about it and play with your changes.

I will be happy to accept PR, I like option 1 seems like more clear API. Internally if possible implementation should share code if possible.

We do not have explicit API for that, change of token usually requires restart of affected services in simples case. You can access private attribute in the pool and change...

I not sure IAM auth is supposed to be used that way, from same doc: > We recommend the following: > > **Use IAM database authentication as a mechanism for...

As for private attribute, password is sitting here: https://github.com/aio-libs/aiomysql/blob/e95df7407bd1ab4612c6307019ea08ab6171d1e8/aiomysql/pool.py#L44 This approach is not supported, and may be broken in next releases, I suggest not to do this.

Probably yes, 3.7 will be released this summer. I can make new release and restrict python version to 3.5.