jetstack
Change threshold to greater than or equal to
What this PR does / why we need it: The StatusCheckFailed_System is a binary value so we must check for when the metric equals one
Fix autorecovery threshold for cloudwatch alarms
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: dippynark
If they are not already assigned, you can assign the PR to them by writing /assign @dippynark in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/assign @dippynark
A bit more background: how have you discovered this?.
The UI shows it somehow like that: StatusCheckFailed_System > 1 for 2 datapoints within 2 minutes
I might have understood it. The sum of 2 datapoints needs to be > 1
@simonswine these blog posts https://aws.amazon.com/blogs/aws/new-auto-recovery-for-amazon-ec2/ and https://aws.amazon.com/blogs/aws/ec2-instance-status-metrics/
Not sure where you are seeing that but it may be grouping them over certain periods. The metric we are setting up is using the minimum so it'd give different results
@dippynark: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| tarmak-puppet-module-tarmak-acceptance-1-14-centos | 4286ee01f244c6d062aa03ffda6f2d8e5908a352 | link | /test puppet-tarmak-acceptance-centos v1.14 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.