jetstack
Make vault-helper download URL customizable
What this PR does / why we need it: This PR lets vault-helper download URL to be modifiable to point to internal mirrors.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #393
Special notes for your reviewer:
Release note:
Allow customizable vault-helper download URL
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mattbates
If they are not already assigned, you can assign the PR to them by writing /assign @mattbates in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I think we need documetation for that and also provide similar things for other downloads we do:
- hyperkube
- vault-helper
- wing
Hi sorry for the delay on the update. I've added the same capability for hyperkube and also reflected those parameters on README files for both modules.
I couldn't find anything related to wing in the puppet/ subfolder so I haven't make any change related to it.
Hi @Wiston999, thanks for the PR. Although I have also created this PR https://github.com/jetstack/tarmak/pull/420 that documents how to customize various URLs in puppet and terraform, I think that it might make more sense to have this as configuration options in the tarmak.yaml . This would prevent having to recompile and provide a much better UX IMO. This can be implemented much like this PR https://github.com/jetstack/tarmak/pull/439 but can also be propagated to terraform to set the wing URL too. Thoughts @simonswine ?
@Wiston999: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.