[WIP] Improve Tarmak Terraform provider
What this PR does / why we need it:
- Fail quickly by checking bastion instance exists when using
bastion_instance_statusdata source - Only create vault init tokens on create operations (no read or delete) with the
vault_instance_roleresource
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #358
Release note:
@dippynark: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: simonswine
Assign the PR to them by writing /assign @simonswine in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
https://github.com/hashicorp/terraform/issues/17034
@dippynark: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@dippynark: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| tarmak-quick-verify | a49d1429d4c895d7914b8f7cdfb247ca13115d42 | link | /test verify quick |
| tarmak-puppet-module-tarmak-acceptance-1-14-centos | a49d1429d4c895d7914b8f7cdfb247ca13115d42 | link | /test puppet-tarmak-acceptance-centos v1.14 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.