tarmak icon indicating copy to clipboard operation
tarmak copied to clipboard

[WIP] Improve Tarmak Terraform provider

Open dippynark opened this issue 7 years ago • 5 comments

What this PR does / why we need it:

  • Fail quickly by checking bastion instance exists when using bastion_instance_status data source
  • Only create vault init tokens on create operations (no read or delete) with the vault_instance_role resource

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #358

Release note:

dippynark avatar Jul 03 '18 09:07 dippynark

@dippynark: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jul 03 '18 09:07 jetstack-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: simonswine

Assign the PR to them by writing /assign @simonswine in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Jul 03 '18 09:07 jetstack-bot

https://github.com/hashicorp/terraform/issues/17034

dippynark avatar Sep 10 '18 12:09 dippynark

@dippynark: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Nov 28 '18 23:11 jetstack-bot

@dippynark: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-quick-verify a49d1429d4c895d7914b8f7cdfb247ca13115d42 link /test verify quick
tarmak-puppet-module-tarmak-acceptance-1-14-centos a49d1429d4c895d7914b8f7cdfb247ca13115d42 link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Apr 11 '19 14:04 jetstack-bot